app: eth2wrap best selector refactoring #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2806 +/- ##
=======================================
Coverage 53.27% 53.27%
=======================================
Files 199 199
Lines 27627 27624 -3
=======================================
Hits 14717 14717
+ Misses 11089 11083 -6
- Partials 1821 1824 +3 ☔ View full report in Codecov by Sentry. |
gsora
approved these changes
Jan 22, 2024
| func (multi) Name() string { | ||
| return "eth2wrap.multi" | ||
| } | ||
|
|
||
| func (m multi) Address() string { | ||
| return m.clients[m.selector.Best()].Address() | ||
| address, ok := m.selector.BestAddress() |
There was a problem hiding this comment.
In what case could BestAddress return ok == false?
There was a problem hiding this comment.
In theory this should never happen, because even after period elapsed, we always add at least one entry to the map. So, this is a safeguard in case somebody changes the logic in Increment and not look into this function.
xenowits
approved these changes
Jan 22, 2024
pinebit
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick refactor of eth2wrap to avoid panic() call, to remove extra loops and to remove ambiguity around address<->index translation.
category: refactor
ticket: none